-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the IsDebugEnabled check from audit expiration #2775
Conversation
{ | ||
logger.Debug($"Batching deletion of {s}-{e} saga history documents."); | ||
} | ||
logger.Debug($"Batching deletion of {s}-{e} saga history documents."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a more general comment for all changes in this PR, where we still use interpolation. For consistency, would it make sense to also use the format-based overloads, like you did in some other changes in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've actually gone the other way and have gone for interpolation rather than using the format overloads. My reasons:
- It's easier to read what the value is when compared to looking at the index number and comparing to the args array
- If we support structured logging in the future, we may be able to pull more meaning from the logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on this. If I read this right, we would have to use the template-based approach outlined in
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/logging/?view=aspnetcore-6.0#log-message-template
docs.microsoft.comdocs.microsoft.com
Which means "not using interpolation".
IsDebugEnabled
appears to be incorrectly set tofalse
possibly due to caching of the value in core. This makes it impossible to get insight into the expiration cleanup process.This PR removes the
IsDebugEnabled
check from the expiration process. This process is not on the hot path for ingestion so skipping the check here should not incur a major performance penalty.